Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Assetic] complete XML configuration examples #6015

Merged
merged 1 commit into from
Dec 18, 2015
Merged

[Assetic] complete XML configuration examples #6015

merged 1 commit into from
Dec 18, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 14, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@xabbuh
Copy link
Member Author

xabbuh commented Dec 14, 2015

You can probably better review this on https://github.com/symfony/symfony-docs/pull/6015/files?w=1.

@wouterj wouterj merged commit 337a9cd into symfony:2.3 Dec 18, 2015
wouterj added a commit that referenced this pull request Dec 18, 2015
@wouterj
minor #6015 [Assetic] complete XML configuration examples (xabbuh)
6098c17 
This PR was merged into the 2.3 branch.

Discussion
----------

[Assetic] complete XML configuration examples

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

337a9cd [Assetic] complete XML configuration examples
wouterj added a commit that referenced this pull request Dec 18, 2015
@wouterj
[#6015] Add missing xsi namespace definition
f70947f
@wouterj
Copy link
Member

wouterj commented Dec 18, 2015

Thanks @xabbuh. I always like your PRs fixing all occurences of some mistake!

Fyi, you forgot to include the namespace definition for the xsi namespace, used in xsi:schemaLocation. I've added them in f70947f.

@xabbuh xabbuh deleted the assetic-xml-examples branch December 18, 2015 06:53
@xabbuh
Copy link
Member Author

xabbuh commented Dec 18, 2015

Great, thanks Wouter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xabbuh @wouterj