Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of minor fixes & applying best practices to form cookbook doc #6050

Merged
merged 12 commits into from
Dec 23, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Dec 19, 2015

This finishes #5569

Q A
doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets -

ThomasLandauer and others added 12 commits December 19, 2015 16:24
| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [yes] 
| Applies to    | [2.3]
| Fixed tickets | []
| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []

I guess it's not necessary to do anything in __construct manually - the ArrayCollection is automatically initialized when you do php app/console doctrine:generate:entities AppBundle

Please double-check!
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |
| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets |[]
| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
"app/Resources/views/Form/fields.html.twig" didn't work for me - see next code block: "form_theme form 'AppBundle:Form:fields.html.twig'"

If this change is correct, I guess it needs to be corrected multiple times on this page.
"the form" sounded like the HTML form.

| Q             | A
| ------------- | ---
| Doc fix?      | [yes]
| New docs?     | [no]
| Applies to    | [2.3]
| Fixed tickets | []
@javiereguiluz
Copy link
Member

👍 nice!

@wouterj wouterj mentioned this pull request Dec 19, 2015
@xabbuh
Copy link
Member

xabbuh commented Dec 23, 2015

Thank you @ThomasLandauer and @wouterj.

@xabbuh xabbuh merged commit 99cdc00 into symfony:2.3 Dec 23, 2015
xabbuh added a commit that referenced this pull request Dec 23, 2015
…kbook doc (ThomasLandauer, WouterJ)

This PR was merged into the 2.3 branch.

Discussion
----------

Lots of minor fixes & applying best practices to form cookbook doc

This finishes #5569

| Q | A
| --- | ---
| doc fix? | yes
| New docs? | no
| Applies to | 2.3+
| Fixed tickets | -

Commits
-------

99cdc00 Revert some changes and fix template names
2b00abe Minor clarification
3ce46f6 Fixed file path
d227ffb Fixed typo
44d19de Added example for 'required' => false
ebb1e74 Update templating.rst
d806300 Typo: Removed comma
6e41f57 Another typo
a4f0318 Fixed typo
275c079 Removed unnecessary(?) YAML hint
9cd391b Note about nesting blocks and {% endblock NAME %}
41f7e6f Changed <meta http-equiv> to HTML5's <meta charset>
@wouterj wouterj deleted the ThomasLandauer-2.3 branch December 23, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants