[cookbook] Add annotations block and fix regex #6124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petk
commented
Jan 10, 2016
petk
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | N/A |
|
👍 thanks for this improvement @peterkokot (I find the code of the |
|
|
||
| $url = str_replace($pathInfo, rtrim($pathInfo, ' /'), $requestUri); | ||
|
|
||
| return $this->redirect($url, 301); |
There was a problem hiding this comment.
We already have the complete code above the configurations so I would reduce this to the bare minimum like this:
.. configuration-block::
.. code-block:: php+annotations::
// src/AppBundle/Controller/RedirectingController.php
/**
* @Route("/{url}", name="remove_trailing_slash",
* requirements={"url" = ".*\/$"}, methods={"GET"})
*/
public function removeTrailingSlashAction(Request $request)
{
// ...
}
|
Do we really need to escape the slash? |
wouterj
added a commit
that referenced
this pull request
Feb 6, 2016
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #6124). Discussion ---------- [cookbook] Add annotations block and fix regex | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | N/A Commits ------- 10e6b30 Add annotations block and fix regex for redirecting URLs with trailing slash
wouterj
added a commit
that referenced
this pull request
Feb 6, 2016
|
Thank you @peterkokot! I've merged your PR into 2.3. It turns out the slash doesn't have to be escaped in the regex, so I reverted that change in d3744cb (I kept it for the annotations, as it's required there). |
|
How are you supposed to
when used with annotations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.