Improveme the apache/mod_php configuration example #6223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # optionally disable the RewriteEngine for the asset directories | ||
| # which will allow apache to simply reply with a 404 when files are | ||
| # not found instead of passing the request into the full symfony stack | ||
| <Directory /var/www/project/web/bundles> |
There was a problem hiding this comment.
this has to be indented 2 spaces back (to be in the same column as the start of the comment)
|
I know almost nothing about Apache config, but I agree with your description and comments in the code. So 👍 from me |
| <Directory /var/www/project/web/bundles> | ||
| AllowOverride None | ||
| Order Allow,Deny | ||
| Allow from All |
There was a problem hiding this comment.
These three lines should be removed (they are already covered by the Directory container for the /var/www/project/web path).
We recently had a project undergo a massive security scan. We had setup email error reporting, so symfony sent us ~15K emails all mostly route not found when the scanner was playing around in the bundles asset directory. In reality if a file isn't available in the bundles directory the server can simply return a 404 not found, and it is probably also slightly more secure and performant to not fire up the entire symfony framework in that case.
|
The latest PR/updated commit should address both comments. |
|
Thank you @gnat42. |
xabbuh
added a commit
that referenced
this pull request
Feb 8, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #6223). Discussion ---------- Improveme the apache/mod_php configuration example We recently had a project undergo a massive security scan. We had setup email error reporting, so symfony sent us ~15K emails all mostly route not found when the scanner was playing around in the bundles asset directory. In reality if a file isn't available in the bundles directory the server can simply return a 404 not found, and it is probably also slightly more secure and performant to not fire up the entire symfony framework in that case. Commits ------- 67b661e Improvement to the apache/mod_php configuration example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a project undergo a massive security scan. We had setup email error reporting, so symfony sent us ~15K emails all mostly route not found when the scanner was playing around in the bundles asset directory. In reality if a file isn't available in the bundles directory the server can simply return a 404 not found, and it is probably also slightly more secure and performant to not fire up the entire symfony framework in that case.