Note to create a service if you extend ExceptionController #6224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had some trouble to get the custom exception handling with inheritance of ExceptionController working, because I hadn't a clue to make a service out of the ExceptionController of the TwigBundle.
| .. note:: | ||
|
|
||
| In case of extending the :class:`Symfony\\Bundle\\TwigBundle\\Controller\\ExceptionController` | ||
| you may configure a service to pass the twig-Environment and the debug-Flag to the constructor. |
There was a problem hiding this comment.
I would replace this:
twig-Environment and the debug-Flag
by this:
Twig environment and the ``debug`` flag
|
@pamuche thanks for your contribution. We love comments from people who followed the docs and faced problems or didn't know how to continue. I've left some comments when reviewing your changes, but overall they look OK to me. Thanks! |
Thank you for your recommendations. It helps me to contribute better additions to the docs in the future.
wouterj
added a commit
that referenced
this pull request
Feb 6, 2016
…r (pamuche) This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6224). Discussion ---------- Note to create a service if you extend ExceptionController I had some trouble to get the custom exception handling with inheritance of ExceptionController working, because I hadn't a clue to make a service out of the ExceptionController of the TwigBundle. Commits ------- fff23f7 Note to create a service if you extend ExceptionController
wouterj
added a commit
that referenced
this pull request
Feb 6, 2016
|
Thank you @pamuche for creating this PR and your quick response to the review! I've merged your pull request into the 2.3 version of the docs (that's the oldest version we maintain) and will merge it up to master from there. After the merge, I've fixed indentation (4 spaces) and added the XML and PHP format for the service in 3b0ea60. Feel free to comment if you have any more questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble to get the custom exception handling with inheritance of ExceptionController working, because I hadn't a clue to make a service out of the ExceptionController of the TwigBundle.