Fixed code example #6256
Closed
Fixed code example #6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new subscriber must be called after the default listener. The default sets the locale as
````php
$locale = $request->attributes->get('_locale');
$request->setLocale($locale);
````
which overwrites any local set before it.
| // must be registered before the default Locale listener | ||
| KernelEvents::REQUEST => array(array('onKernelRequest', 17)), | ||
| // must be registered after the default Locale listener | ||
| KernelEvents::REQUEST => array(array('onKernelRequest', 16)), |
There was a problem hiding this comment.
let's use 15 to be sure that it's executed after (the default listener is on 16)
|
👍 Seems 100% valid to me, thanks for submitting the fix! |
|
👍 |
|
Good catch, thanks @twifty. |
xabbuh
added a commit
that referenced
this pull request
Feb 12, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #6256). Discussion ---------- Fixed code example The new subscriber must be called after the default listener. The default sets the locale as ````php $locale = $request->attributes->get('_locale'); $request->setLocale($locale); ```` which overwrites any local set before it. Commits ------- 50bca94 Fixed code example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new subscriber must be called after the default listener. The default sets the locale as
which overwrites any local set before it.