[quick tour] mostly typos #6275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paxyknox
commented
Feb 15, 2016
paxyknox
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | x |
| @@ -309,4 +309,4 @@ need to learn a lot to become a Symfony master. Ready to dig into these | |||
| topics now? Look no further - go to the official :doc:`/book/index` and | |||
| pick any topic you want. | |||
|
|
|||
| .. _Composer: https://getcomposer.org | |||
| .. _`Composer`: https://getcomposer.org | |||
There was a problem hiding this comment.
This is technically not wrong ... but I prefer this syntax too :)
There was a problem hiding this comment.
The proposed changed is more common throughout the documentation.
|
I need to find some time to review this as this is really a lot of changes. On the first glance they look good but I need to do some deeper reviewing. I cannot promise when I will have the time to do the review but please feel free to ping me if I forget about it. |
| When you browsed ``http://localhost:8000/app/example`` earlier, Symfony executed | ||
| the controller defined in the ``src/AppBundle/Controller/DefaultController.php`` | ||
| If you'd browsed ``http://localhost:8000/app/example`` for example, Symfony could | ||
| executed the controller defined in the ``src/AppBundle/Controller/DefaultController.php`` |
There was a problem hiding this comment.
When you go to ``http://localhost:8000/app/example``, Symfony will execute the
controller in ``src/AppBundle/Controller/DefaultController.php`` and render the ...
|
👍 once @paxyknox can make the changes mention in the comments. Thanks! |
| @@ -43,7 +44,7 @@ Actions and Controllers | |||
| ~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| Open the ``src/AppBundle/Controller/DefaultController.php`` file and you'll | |||
| see the following code (for now, don't look at the ``@Route`` configuration | |||
| see the following code (for now, don't look at the ``@Route()`` configuration | |||
There was a problem hiding this comment.
I'm -1 on this change, annotations are like classes. We use the () to indicate functions
|
I made requested changes. |
|
👍 Thanks for the detailed review and fixes @paxyknox! |
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 2.3: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 2.7: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 2.8: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 3.0: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos Fix reference to app folder [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.