Updated Heroku instructions #6394
Conversation
With the newer versions of the Heroku toolbelt, multiple buildpacks is supported by default.
| $ heroku buildpacks:set heroku/nodejs | ||
| Buildpack set. Next release on your-application will use heroku/nodejs. | ||
| Run git push heroku master to create a new release using this buildpack. | ||
| $ heroku buildpacks:set heroku/php --index 2 |
There was a problem hiding this comment.
you could just use heroku buildpacks:add
There was a problem hiding this comment.
I considered that, but in the end I thought this was better because this way is idempotent.
There was a problem hiding this comment.
Isn't buildpacks:add added for exactly this usage (please note that I don't know anything about heroku)? If it is, I think we should use it instead of the current situation
There was a problem hiding this comment.
It sort of is, but the problem is that build pack order matters. In order to be able to use a composer post-install hook for e.g. Gulp, the node build pack needs to come before the PHP build pack. Just using buildpacks:add makes the process depend on the state of the application. The process I describe is idempotent.
| use a special `multiple buildpack`_. To override buildpack auto-detection, you | ||
| need to explicitly set the buildpack URL: | ||
| now ignored. To compile your app with both buildpacks, Node.js *and* PHP, you need | ||
| use both buildpacks. To override buildpack auto-detection, you |
|
👍 LGTM |
| use a special `multiple buildpack`_. To override buildpack auto-detection, you | ||
| need to explicitly set the buildpack URL: | ||
| now ignored. To compile your app with both buildpacks, Node.js *and* PHP, you need | ||
| to use both buildpacks. To override buildpack auto-detection, you |
There was a problem hiding this comment.
Effectively, you're saying "To use both builds packs, you need to use both buildpacks." That's kind of strange. What about changing this to "To compile your app with both buildpacks, override the buildpack auto-detection with the buildpacks:set command:"
There was a problem hiding this comment.
I would rather use something like "To compile your app with both buildpacks, manually select them with the buildpacks:set command" (because the key concept here isn't that you're overriding the auto-detection, but rather that you're using multiple packs).
|
Thanks Magnus! |
This PR was merged into the 2.3 branch. Discussion ---------- Updated Heroku instructions | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >=2.3 | Fixed tickets | With newer versions of the Heroku toolbelt, multiple buildpacks is supported natively. Commits ------- 204425c Fixed grammatical error 44e44f9 Comment updates 05a0afd Updated Heroku instructions
With newer versions of the Heroku toolbelt, multiple buildpacks is supported natively.