Update routing.rst #6419
Closed
Update routing.rst #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change was breaking existing functionality, need to preserve it.
| @@ -33,7 +33,7 @@ As we now extract the request query parameters, simplify the ``hello.php`` | |||
| template as follows:: | |||
|
|
|||
| <!-- example.com/src/pages/hello.php --> | |||
| Hello <?php echo htmlspecialchars($name, ENT_QUOTES, 'UTF-8') ?> | |||
| Hello <?php echo htmlspecialchars(isset($name) ?: 'World', ENT_QUOTES, 'UTF-8') ?> | |||
There was a problem hiding this comment.
shouldn't it be isset($name) ? $name : 'World' ?
There was a problem hiding this comment.
You are right! Thx!
fixed thx to @Ener-Getick
|
👍 |
1 similar comment
|
👍 |
|
Thank you @tamtamchik. |
xabbuh
added a commit
that referenced
this pull request
May 21, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6419). Discussion ---------- Update routing.rst | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | none The described version of the file was breaking "default value" functionality, and if user would access this page without `name` variable it'll get warning: `Notice: Undefined variable: name in ../src/pages/hello.php on line 2` Commits ------- a29a319 Update routing.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The described version of the file was breaking "default value" functionality, and if user would access this page without
namevariable it'll get warning:Notice: Undefined variable: name in ../src/pages/hello.php on line 2