Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tip for optional second parameter for form submissions. #6420

Merged
merged 1 commit into from
Apr 6, 2016
Merged

Added tip for optional second parameter for form submissions. #6420

merged 1 commit into from
Apr 6, 2016

Conversation

michaeljoelphillips
Copy link

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #6415


When submitting a form via a "PATCH" request, you may want to update only a few
submitted fields. To achieve this, you may pass an optional second boolean
parameter to ``submit()``. Passing ``false`` will remove any missing fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Form::submit().

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeahDude Shouldn't it be $form->submit(…) instead, as in the example above the tip?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't answer that :) I just thought it would be more clear to mention the class involved by that method.

ping @symfony/documentors !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary. Above this example we already link to the API docs of submit() twice. That should be clear enough.

@HeahDude
Copy link
Contributor

HeahDude commented Apr 1, 2016

👍 Looks good

@javiereguiluz
Copy link
Member

Nice tip! Thank you @Nomad145

@xabbuh
Copy link
Member

xabbuh commented Apr 1, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented Apr 6, 2016

Thank you @Nomad145.

@xabbuh xabbuh merged commit 153219a into symfony:2.3 Apr 6, 2016
xabbuh added a commit that referenced this pull request Apr 6, 2016
…ons. (Michael Phillips)

This PR was merged into the 2.3 branch.

Discussion
----------

Added tip for optional second parameter for form submissions.

| Q              | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #6415

Commits
-------

153219a Added tip for optional second parameter for form submissions.
@michaeljoelphillips michaeljoelphillips deleted the submit_patch branch April 9, 2016 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants