Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http_kernel_httpkernel_class.rst #6509

Closed
wants to merge 1 commit into from

Conversation

AchillesKal
Copy link
Contributor

The current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers.

The current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers.
@xabbuh
Copy link
Member

xabbuh commented Apr 21, 2016

👍

xabbuh added a commit that referenced this pull request Apr 24, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.8 branch instead (closes #6509).

Discussion
----------

Update http_kernel_httpkernel_class.rst

The current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers.

Commits
-------

ee94747 Update http_kernel_httpkernel_class.rst
@xabbuh
Copy link
Member

xabbuh commented Apr 24, 2016

Thank you @AchillesKal! I have merged your changes into the 2.8 branch where this is already the recommended way. That's why your PR is shown as closed instead of merged. Though you will still get the full credit for your contribution.

@xabbuh xabbuh closed this Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants