[DependencyInjection] Unquote services FQCN in autowiring examples #6529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated to this PR, but those FQCN looks strange. This is the component doc, so |
|
@javiereguiluz I was a bit confused, I saw this chapter so I was thinking that the |
|
👍 I don't really care much about this. But let's merge this as it's consistent and you put effort into fixing it! |
xabbuh
added a commit
that referenced
this pull request
May 9, 2016
…vices examples (chalasr) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] Unquote services FQCN in parent-services examples Same as #6529 on a older chapter, with some incoherences fixed (sometimes double quotes, simple quotes, and, as it should be, no quotes). Commits ------- e39278e [DependencyInjection] Unquote services FQCN in parent-services examples
|
Thank you @chalasr. |
xabbuh
added a commit
that referenced
this pull request
May 9, 2016
… examples (chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [DependencyInjection] Unquote services FQCN in autowiring examples In most examples of service declaration, the `class` value has no quotes, but in this one, they have simple quotes. Commits ------- 54d84e4 [DependencyInjection] Unquote services FQCN in autowiring examples
wouterj
added a commit
that referenced
this pull request
May 13, 2016
This PR was merged into the 2.8 branch. Discussion ---------- drop AppBundle examples in components section fixes #6529 (comment) Commits ------- bd4bb34 drop AppBundle examples in components section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most examples of service declaration, the
classvalue has no quotes, but in this one, they have simple quotes.