Trusted proxies were removed when URL signing took over #6541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .. index:: | ||
| single: Request; Trusted Proxies | ||
|
|
||
| Trusting Proxies |
There was a problem hiding this comment.
this removal is wrong. We still have trusted proxies (even though ESI accepts signed requests from anywhere)
|
the commit you linked does not remove trusted proxies at all. It removed their usage in a single place which was not working properly |
…o ``trusted_proxies``
rawkode
force-pushed
the
bugfix/remove-all-mention-of-trusted-proxies
branch
from
da10763
to
1bf084d
Compare
|
Sorry, @stof - silly assumption on my part. I've removed all the daft removals. TIL more about Symfony and the FragmentListener 👍 |
|
👍 |
wouterj
added a commit
that referenced
this pull request
May 21, 2016
…rawkode) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #6541). Discussion ---------- Trusted proxies were removed when URL signing took over Since: symfony/http-kernel@fa8f4f8 Commits ------- 853825b Removing incorrect reference that the FragmentListener only listens to ``trusted_proxies``
|
Thank you @rawkode for updating the code. As this security fix was merged into the 2.3 version of the code, I've merged this into the 2.3 version of the docs as well. I'll take care of merging it into the other versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since: symfony/http-kernel@fa8f4f8