Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lazy_services.rst #6559

Closed
wants to merge 3 commits into from
Closed

Update lazy_services.rst #6559

wants to merge 3 commits into from

Conversation

hboomsma
Copy link

Q A
Doc fix? yes
New docs? no
Applies to ^3.0.0
Fixed tickets

�$ composer require ocramius/proxy-manager:~2.0 instead of 1.0

Hidde Boomsma added 2 commits May 10, 2016 17:23
�$ composer require ocramius/proxy-manager:~2.0 instead of 1.0
hint the right version per PHP version.
@@ -36,8 +36,8 @@ the `ProxyManager bridge`_:
So, run:

.. code-block:: bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blank line needs to be preserved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line is back 👍

The blank line needs to be preserved.
@wouterj
Copy link
Member

wouterj commented May 13, 2016

Hmm, I wonder if there is some breaking changes between 1.0 and 2.0 that we have in the docs? If there are none, I would just remove the version number here (composer require ocramius/proxy-manager).

@stof
Copy link
Member

stof commented May 13, 2016

@wouterj the main BC break is that version 2 requires PHP 7 (which is why listing it as an explicit version is a bad idea btw)

wouterj added a commit that referenced this pull request Jul 8, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #6559).

Discussion
----------

Update lazy_services.rst

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | ^3.0.0
| Fixed tickets |

�$ composer require ocramius/proxy-manager:~2.0 instead of 1.0

Commits
-------

1f18702 Update lazy_services.rst
wouterj added a commit that referenced this pull request Jul 8, 2016
@wouterj
Copy link
Member

wouterj commented Jul 8, 2016

Thanks @hboomsma! I've merged your PR into the 2.7 version of the docs and removed the version constraint in f24f585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants