Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] use static Yaml API #6598

Merged
merged 1 commit into from
May 21, 2016
Merged

[Yaml] use static Yaml API #6598

merged 1 commit into from
May 21, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 21, 2016

I don't see a good reasons to explicitly describe the non-static API. If you ever really need to use the Parser and Dumper classes directly, you will be able to easily figure out how to use them yourself.

@HeahDude
Copy link
Contributor

👍

@wouterj
Copy link
Member

wouterj commented May 21, 2016

👍

$value = $yaml->parse(file_get_contents('/path/to/file.yml'));
Because it is currently possible to pass a filename to this method, you
must validate the input first. Passing a filename is deprecated in
Symfony 2.2, and will be removed in Symfony 3.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be removed -> was removed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@javiereguiluz
Copy link
Member

A big 👍 from me!

@wouterj
Copy link
Member

wouterj commented May 21, 2016

Thanks Christian.

@wouterj wouterj merged commit 7dd4bae into symfony:2.3 May 21, 2016
wouterj added a commit that referenced this pull request May 21, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] use static Yaml API

I don't see a good reasons to explicitly describe the non-static API. If you ever really need to use the `Parser` and `Dumper` classes directly, you will be able to easily figure out how to use them yourself.

Commits
-------

7dd4bae use static Yaml API
@xabbuh xabbuh deleted the yaml-tweaks branch May 21, 2016 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants