Added a note about coding standards and method arguments #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,6 +160,9 @@ Structure | |||
| ``tearDown`` methods of PHPUnit tests, which should always be the first methods | |||
| to increase readability; | |||
|
|
|||
| * Declare all the arguments in the same line as the method/function name, no | |||
There was a problem hiding this comment.
I'm sorry I don't understand this comment.
There was a problem hiding this comment.
See the second example of http://www.php-fig.org/psr/psr-2/#4-1-extends-and-implements
There was a problem hiding this comment.
Something like this, inspired from @wouterj link.
Right:
class ClassName extends ParentClass implements \ArrayAccess, \Countable
{
// constants, properties, methods
}Wrong:
class ClassName extends ParentClass implements
\ArrayAccess,
\Countable,
\Serializable
{
// constants, properties, methods
}There was a problem hiding this comment.
Thanks for explaining it to me. In 59a09bf I've proposed something for this.
There was a problem hiding this comment.
this has to be "on the same line" as well
| @@ -153,13 +153,19 @@ Structure | |||
| that are not intended to be instantiated from the outside and thus are not | |||
| concerned by the `PSR-0`_ and `PSR-4`_ autoload standards; | |||
|
|
|||
| * Declare the class inheritance (if any) and all the implemented interfaces (if | |||
| any) in the same line as the class name; | |||
There was a problem hiding this comment.
I don't think "if any" is needed here.
There was a problem hiding this comment.
I agree. Done both changes. Thanks.
|
LGTM. 👍 |
|
👍 |
|
👍 |
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Jun 6, 2016
…(javiereguiluz) This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6618). Discussion ---------- Added a note about coding standards and method arguments This coding standard is optional in the PSR-2 standard, so we must explain our own convention. Related to symfony/symfony#18890. Commits ------- b7429a5 Added a note about coding standards and method arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This coding standard is optional in the PSR-2 standard, so we must explain our own convention. Related to symfony/symfony#18890.