Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monolog.rst #6700

Closed
wants to merge 2 commits into from
Closed

Update monolog.rst #6700

wants to merge 2 commits into from

Conversation

zhil
Copy link
Contributor

@zhil zhil commented Jun 30, 2016

Default value for buffer_size is unlimited, which worth being mentioned

Default value for buffer_size is unlimited, which worth being mentioned
@zhil
Copy link
Contributor Author

zhil commented Jun 30, 2016

according to https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/Configuration.php default value is unlimited, not 30

@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2016

looks like the XML example would need to be updated too

@zhil
Copy link
Contributor Author

zhil commented Jul 7, 2016

@xabbuh I have updated xml as well

@javiereguiluz
Copy link
Member

👍

Status: reviewed


@zhil a very nice catch in a very important document. We must be extra-careful in the configuration references to not make any mistake.

wouterj added a commit that referenced this pull request Jul 8, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6700).

Discussion
----------

Update monolog.rst

Default value for buffer_size is unlimited, which worth being mentioned

Commits
-------

c5a2d9e Update monolog.rst
wouterj added a commit that referenced this pull request Jul 8, 2016
@wouterj
Copy link
Member

wouterj commented Jul 8, 2016

Thanks @zhil!

Fyi, I've merged this PR in the 2.7 version of the docs. I'll update the more recent versions from there.

@wouterj wouterj closed this Jul 8, 2016
@zhil
Copy link
Contributor Author

zhil commented Jul 20, 2016

@wouterj @javiereguiluz @xabbuh
probably, it would be nice to notice in documentation, that by defaults monolog stop buffering logs after first error (stop_buffering is true by default).
So, complicated console commands could generate gigabytes of logs easily - just fixed it on production.

should I create PR for it?

@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2016

@zhil I think that would be a good idea. Are you still interested in creating a PR?

@zhil
Copy link
Contributor Author

zhil commented Oct 20, 2016

@xabbuh well, technically, its already documented
https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/Configuration.php#L93

IMHO "stop_buffering" is confusing term itself. If its set to true (default value) - finger_crossed in fact disabled after first error and everything after first error are placed in logs.

Tthats correct approach for websites, but could be wrong for command line scripts. (If script do a lot of work in loops, it could create much more logs, as expected).

I am not sure, where exactly should I add notice about it. Mayb short notice like "Please note, that by default fingers_crossed could create huge logs for command line scripts after first error"

@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2016

@zhil Is that the only place where we document that option?

@zhil
Copy link
Contributor Author

zhil commented Oct 20, 2016

@xabbuh
Copy link
Member

xabbuh commented Oct 21, 2016

@zhil Yeah, I think the former one is a must have, in the latter one we can probably omit it to not confuse the reader with too many details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants