Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the instructions to build docs locally #6835

Merged
merged 8 commits into from
Aug 20, 2016

Conversation

javiereguiluz
Copy link
Member

This finishes #6395.


$ pip install sphinx~=1.3.0 git+https://github.com/fabpot/sphinx-php.git

**Step 3.** Run ``make html`` and view the generated documentation in the
Copy link

@snoek09 snoek09 Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be mentioned that make html has to be run inside the _build dir as the Makefile has been moved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you. I've reworded this a bit in a7b4d32.

@snoek09
Copy link

snoek09 commented Aug 3, 2016

👍

Status: Reviewed


$ pip install sphinx~=1.3.0 git+https://github.com/fabpot/sphinx-php.git

**Step 3.** Run the following command to build the documentation in HTML format:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use an ordered list here

@yceruto
Copy link
Member

yceruto commented Aug 3, 2016

I've tried this in Windows and not work for me :/

...\symfony-docs\_build>make html
Running Sphinx v1.3.1
making output directory...
A Translator for the html builder is changed.
loading pickled environment... not yet created
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 0 source files that are out of date
updating environment: 0 added, 0 changed, 0 removed
WARNING: master file ...\symfony-docs\_build\index.rst not found
looking for now-outdated files... none found
no targets are out of date.
build succeeded, 1 warning.

Build finished. The HTML pages are in _build/html.

... and the path _build/html is empty.

@javiereguiluz
Copy link
Member Author

@yceruto the error seems to be in this line:

WARNING: master file ...\symfony-docs\_build\index.rst not found

@wouterj
Copy link
Member

wouterj commented Aug 3, 2016

make html should be run in \symfony-docs. (using "_build/make" html or _build\make html)


.. code-block:: bash

$ _build\make html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on Unix, it should be ./_build/make html IIRC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this part should be split in two sections ? Unix and Windows ?

@yceruto
Copy link
Member

yceruto commented Aug 3, 2016

@wouterj symfony-docs>_build\make html work perfect, thanks.

On the other hand, inside symfony-docs/_build/_theme/_templates/layout.html was declared the main assets to external urls:

  • css http://symfony.com/css/compiled/v5/all.css?v=4
  • js http://symfony.com/js/v5/all.js?v=4

this not work offline, any solution ?

@yceruto
Copy link
Member

yceruto commented Aug 3, 2016

The same for all *.svg paths inside http://symfony.com/css/compiled/v5/all.css, they aren't offline.

@yceruto
Copy link
Member

yceruto commented Aug 3, 2016

I just created a separate issue for these questions, because they are out of scope of this PR. #6844

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Alternatively you can build the documentation in your own computer following
these steps:
Copy link
Member

@yceruto yceruto Aug 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I was confused in thinking that could build the documentation locally and use it completely "offline", which it's not possible right now and probably never will #6844 (comment). Maybe we can add the subject "only for testing purpose" somehow? The previous title/description it was clearer in this sense, thanks.

@wouterj
Copy link
Member

wouterj commented Aug 5, 2016

👍

Build the Documentation Locally
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Alternatively you can build the documentation in your own computer for testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on your own computer

@weaverryan
Copy link
Member

Thanks Javier!

@weaverryan weaverryan merged commit a2428a4 into symfony:2.7 Aug 20, 2016
weaverryan added a commit that referenced this pull request Aug 20, 2016
…iluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Updated the instructions to build docs locally

This finishes #6395.

Commits
-------

a2428a4 Minor improvements
914dd30 Fixed the "make" command
77c88bf Fixed again the tricky list syntax
767b49b Fixed the syntax of the list
c71ad4b Minor fixes
a7b4d32 Reword the third step
cebc382 Added the missing link references
348b11c Updated the instructions to build docs locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants