Fix Cache Pools: SQLite3Cache constructor argument #6852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argument for SQLite3Cache should be of type SQLite3 instead of a string
|
Agreed 👍 status: reviewed |
|
👍 |
|
Thank you for testing & fixing the code in the docs! |
wouterj
added a commit
that referenced
this pull request
Aug 11, 2016
This PR was merged into the 3.1 branch. Discussion ---------- Fix Cache Pools: SQLite3Cache constructor argument The first argument for SQLite3Cache should be of type SQLite3 instead of a string https://github.com/doctrine/cache/blob/master/lib/Doctrine/Common/Cache/SQLite3Cache.php#L68 Commits ------- 1a8c9ab Fix Cache Pools: SQLite3Cache constructor argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument for SQLite3Cache should be of type SQLite3 instead of a string
https://github.com/doctrine/cache/blob/master/lib/Doctrine/Common/Cache/SQLite3Cache.php#L68