service_container : fix php Definition instance #6884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing really important ^^, just according YAML format with PHP format
|
Thanks for updating the example! 👍
Unfortunately for you, the You can ask for help using one of the support channels. |
|
Really nice catch @ReDnAxE. Thanks ! |
weaverryan
added a commit
that referenced
this pull request
Aug 21, 2016
This PR was merged into the 2.7 branch.
Discussion
----------
service_container : fix php Definition instance
Nothing really important ^^, just according YAML format with PHP format.
I have a question but I don't know where I can ask ^^ :
The doc says that $container->register is a shortcut of definition method [("shortcut for the previous method")](http://symfony.com/doc/current/service_container/definitions.html#getting-and-setting-service-definitions).
But for me definition method is not the same as directly register service in containerBuidler.
Is there a place where I can post my questions ?
EDIT: I think this is not a justified PR, if so, sorry for the time spent
Commits
-------
20590f5 service_container : fix php Definition instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing really important ^^, just according YAML format with PHP format.
I have a question but I don't know where I can ask ^^ :
The doc says that $container->register is a shortcut of definition method ("shortcut for the previous method").
But for me definition method is not the same as directly register service in containerBuidler.
Is there a place where I can post my questions ?
EDIT: I think this is not a justified PR, if so, sorry for the time spent