Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article about logout. #6911

Closed
wants to merge 1 commit into from
Closed

Article about logout. #6911

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2016

In this lesson, we go through the authorization HTTP BASIC. I have tried to use this example and in the end got the exact same error again and again. The Internet has a lot of open topics about this. Like many other people, I have scroll lesson up to understand where I made a mistake. I think you need to specify that this is not a working example (in this context) it will save a lot of time people who study it.

In this lesson, we go through the authorization HTTP BASIC. I have tried to use this example and in the end got the exact same error again and again. The Internet has a lot of open topics about this. Like many other people, I have scroll lesson up to understand where I made a mistake. I think you need to specify that this is not a working example (in this context) it will save a lot of time people who study it.
@wouterj
Copy link
Member

wouterj commented Aug 28, 2016

I agree for 100% 👍

status: reviewed

@ghost
Copy link
Author

ghost commented Aug 28, 2016

@wouterj wow) that cool :D now i'm symfony-docs contributor ;) I hope the next time my contribution will be more)

@ghost ghost closed this Sep 9, 2016
@ghost ghost reopened this Sep 9, 2016
xabbuh added a commit that referenced this pull request Sep 21, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6911).

Discussion
----------

Article about logout.

In this lesson, we go through the authorization HTTP BASIC. I have tried to use this example and in the end got the exact same error again and again. The Internet has a lot of open topics about this. Like many other people, I have scroll lesson up to understand where I made a mistake. I think you need to specify that this is not a working example (in this context) it will save a lot of time people who study it.

Commits
-------

c64ca7a Article about logout.
@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

Thank you @BorodinDemid! Contributions like this where you realised while reading that things could be improved help us to make the docs better. Hope to see you back soon with your next PR. :)

FYI, I have merged your PR into the 2.7 branch which is the oldest still maintained branch that was needing this too. That's why it is shown as closed instead of merged (though you will still get the credits for your contribution). From there I will merge things up to master. So you will see your changes online for all still maintained branches soon.

@xabbuh xabbuh closed this Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants