[Config] Note about bundle priority for PrependExtensionInterface #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wodor
changed the title
weaverryan
reviewed
Sep 18, 2016
| More than one bundle using PrependExtensionInterface | ||
| ---------------------------------------------------- | ||
|
|
||
| When there is more than one bundle prepending the same extension and defining the same key, the bundle that is registered **first** will take priority and next bundles won't override this specific config setting. |
There was a problem hiding this comment.
Minor re-wording and line breaks:
If there is more than one bundle that prepends the same extension and defines
the same key, the bundle that is registered **first** will take priority: next
bundles won't override this specific config setting.
weaverryan
reviewed
Sep 18, 2016
| @@ -131,3 +131,8 @@ The above would be the equivalent of writing the following into the | |||
| // ... | |||
| 'use_acme_goodbye' => false, | |||
| )); | |||
|
|
|||
| More than one bundle using PrependExtensionInterface | |||
| ---------------------------------------------------- | |||
|
I added some rewording, but you're correct, and I like this small note at the end: 👍 Status: Reviewed |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
…nterface (wodor) This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6920). Discussion ---------- [Config] Note about bundle priority for PrependExtensionInterface I've stumbled upon problem that my config setting wasn't prepended using PrependExtensionInterface. It was because I didn’t know that first bundle takes priority when it comes to overriding exactly the same config key. Commits ------- 34d8d48 Note about bundle priority for PrependExtensionInterface
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
|
Thank you @wodor! I have merged your changes into the |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
* 2.7: (24 commits) [#6934] add remember me response listener Update events.rst [#6920] some tweaks after review Note about bundle priority for PrependExtensionInterface [#6905] rewrite code example to cover the setter Change example of ignoring dependencies for yaml [FormComponent]Fix wrong mention in side note Article about logout. Clarify by_reference use Use Terminal lexer for console examples Update entity_provider.rst fixing $formatLevelMap array values Fix subject/verb agreement Fixed directory name type fix link role syntax Update voters.rst Improved the title of Validation Groups article to make it easier to find it Minor reword Fix minor typo in security chapter How to Build a Traditional Login Form Update composer.rst ...
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
* 2.8: (32 commits) [#6989] some minor tweaks Added paths options in Framework::translator configuration [#6934] add remember me response listener Update events.rst [#6897] some tweaks after review Update voters.rst [#6920] some tweaks after review Note about bundle priority for PrependExtensionInterface [#6926] some tweaks after review [#6905] rewrite code example to cover the setter Change example of ignoring dependencies for yaml [FormComponent]Fix wrong mention in side note Article about logout. Clarify by_reference use Use Terminal lexer for console examples Update entity_provider.rst fixing $formatLevelMap array values Fix subject/verb agreement Fixed directory name type fix link role syntax ...
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
* 3.1: (50 commits) Update heroku.rst [#6989] some minor tweaks Added paths options in Framework::translator configuration [#6934] add remember me response listener Update events.rst [#6897] some tweaks after review Update voters.rst [#6920] some tweaks after review Note about bundle priority for PrependExtensionInterface [#6926] some tweaks after review [#6905] rewrite code example to cover the setter Change example of ignoring dependencies for yaml [FormComponent]Fix wrong mention in side note Article about logout. Clarify by_reference use Use Terminal lexer for console examples Update entity_provider.rst fixing $formatLevelMap array values Use the standard cache and logs dir for the micro kernel example Fix subject/verb agreement ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled upon problem that my config setting wasn't prepended using PrependExtensionInterface. It was because I didn’t know that first bundle takes priority when it comes to overriding exactly the same config key.