Misplaced paragraph about placeholders in routing.rst #6933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks that this paragraph was only a misplaced duplicate
|
@antoin-m very nice issue report! Thanks a lot. 👍 Status: reviewed |
|
Good catch, thanks @antoin-m. |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
…toin-m) This PR was merged into the 2.7 branch. Discussion ---------- Misplaced paragraph about placeholders in routing.rst It looks that this paragraph was only a misplaced duplicate of [this block](https://github.com/symfony/symfony-docs/blame/c72dde0a8e90ec9fb90b31e472b2c1e0fac35a37/routing.rst#L259-L262) As you can see on [this commit](6e48cee?short_path=51326f5#diff-3b3b9409bff44f4b31ba1f933dbf0001L338) the paragraph was originally added to the [Giving {placeholders} a Default Value](https://github.com/symfony/symfony-docs/blob/2.7/routing.rst#giving-placeholders-a-default-value) part. Commits ------- 6dcf85a Update routing.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks that this paragraph was only a misplaced duplicate of this block
As you can see on this commit the paragraph was originally added to the Giving {placeholders} a Default Value part.