Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the standard cache and logs dir for the micro kernel example #6935

Closed
wants to merge 1 commit into from
Closed

Use the standard cache and logs dir for the micro kernel example #6935

wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

This fixes #6868.

@weaverryan
Copy link
Member

👍

Status: Reviewed

xabbuh added a commit that referenced this pull request Sep 21, 2016
@xabbuh
minor #6935 Use the standard cache and logs dir for the micro kernel …
7be8b3f 
…example (javiereguiluz)

This PR was submitted for the 3.0 branch but it was merged into the 3.1 branch instead (closes #6935).

Discussion
----------

Use the standard cache and logs dir for the micro kernel example

This fixes #6868.

Commits
-------

ca53cb5 Use the standard cache and logs dir for the micro kernel example
@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

Thanks Javier. Maybe it's just me, but I actually find dirname(__DIR__) not really readable. Thus, I suggest we use __DIR__.'/.. as we already do above in configureRoutes().

@xabbuh xabbuh closed this Sep 21, 2016
@javiereguiluz javiereguiluz deleted the fix_6868 branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@javiereguiluz @weaverryan @xabbuh @carsonbot