Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor tweaks #7028

Merged
merged 1 commit into from
Oct 6, 2016
Merged

A few minor tweaks #7028

merged 1 commit into from
Oct 6, 2016

Conversation

bocharsky-bw
Copy link
Contributor

No description provided.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks @bocharsky-bw

@@ -344,7 +344,7 @@ files are always in sync.

When you :ref:`install an existing Symfony project <install-existing-app>`, you
will need to create the ``parameters.yml`` file using the committed ``parameters.yml.dist``
file as a reference. To help with this, after you run ``composer install``, a
file as a reference. To help with this, after you run ``$ composer install``, a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For commands displayed inside a paragraph we don't include the leading $, only for proper console blocks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, I reverted it

@wouterj
Copy link
Member

wouterj commented Oct 3, 2016

👍

status: reviewed

@wouterj
Copy link
Member

wouterj commented Oct 6, 2016

Perfect PR, thanks! Lots of very good catches. (btw, I personally always use config:dump, which also works because of the abbr support of the Console component)

@wouterj wouterj merged commit edaab10 into symfony:2.7 Oct 6, 2016
wouterj added a commit that referenced this pull request Oct 6, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

A few minor tweaks

Commits
-------

edaab10 A few minor tweaks
@bocharsky-bw bocharsky-bw deleted the patch-7 branch October 7, 2016 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants