Redirect /form to /forms for consistency #7035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this also redirect @javiereguiluz I think you implemented the redirection logic. Can you please check this? |
|
@xabbuh no, that won't happen. The exception listener takes the contents of https://github.com/symfony/symfony-docs/blob/master/_build/redirection_map and treats each entry as a separate URL, so only |
|
Thank you Wouter. |
xabbuh
added a commit
that referenced
this pull request
Oct 14, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Redirect /form to /forms for consistency The main guide is called `/forms`, but the sub-guides are in `/form/...`. When restructuring the docs, we decided this was the correct naming, so we shouldn't change this. However, I think it would be nice to redirect `/form` to `/forms` (I'm used to simply remove the sub-guide slug from the URL to visit the main guide). Commits ------- d8e4abe Redirect /form to /forms for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main guide is called
/forms, but the sub-guides are in/form/.... When restructuring the docs, we decided this was the correct naming, so we shouldn't change this.However, I think it would be nice to redirect
/formto/forms(I'm used to simply remove the sub-guide slug from the URL to visit the main guide).