Remove suggestion to change the .class parameters
#7090
Conversation
To my knowledge, this practice has been discouraged and the corresponding configuration hooks have been dropped in Symfony 3.0.
| If you want to modify service definitions of another bundle, you can use a compiler | ||
| pass to change the class of the service or to modify method calls. In the following | ||
| example, the implementing class for the ``original-service-id`` is changed to | ||
| ``Acme\DemoBundle\YourService`. |
There was a problem hiding this comment.
this is missing the second backtick after the class name
| If you want to modify service definitions of another bundle, you can use a compiler | ||
| pass to change the class of the service or to modify method calls. In the following | ||
| example, the implementing class for the ``original-service-id`` is changed to | ||
| ``Acme\DemoBundle\YourService``. |
There was a problem hiding this comment.
Oh, we need to end this paragraph with two colons so that the following paragraph is actually interpreted as a code block.
|
For the records, this will fix #7093. |
|
👍 (except that we don't support 3.0 anymore, I suggest to merge it straight into 2.7) |
|
@wouterj wait, I think for 2.7 it's still ok. Pick a 3.x branch of your choice. Should we add a note on 2.x that this is discouraged? |
|
Also, would it help to add a pointer to decorated services, or do they solve another problem? |
|
Thank you @mpdude. |
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #7090). Discussion ---------- Remove suggestion to change the `.class` parameters To my knowledge, this practice has been discouraged and the corresponding configuration hooks have been dropped in Symfony 3.0. Commits ------- 4d59cad Remove suggestion to change the parameters
|
@mpdude Mentioning service decoration here sounds useful (a short paragraph linking to the existing chapter should be enough). |
To my knowledge, this practice has been discouraged and the corresponding configuration hooks have been dropped in Symfony 3.0.