[Workflow] Add tip for workflow configuration default values #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
requested changes
Jan 8, 2017
|
@javiereguiluz thanks for CR. I've rewritten tip to be clearer. If you have additional suggestions please let me know. |
|
@dominikhajduk thanks for this reword. I can now understand everything perfectly 👍 |
xabbuh
reviewed
Jan 10, 2017
|
|
||
| Workflow configuration ``type`` and ``arguments`` in ``marking_store`` section | ||
| are optional. You can skip one or both when you use default values. Default value | ||
| for ``type`` is "single_state". Default value for ``arguments`` is "marking". |
There was a problem hiding this comment.
I would reword this a bit to something like this:
The
type(default valuesingle_state) andarguments(default valuemarking) attributes of themarking_storeoption are optional. If omitted, their default values will be used.
What do you think?
There was a problem hiding this comment.
@xabbuh fine for me. Will change in couple of seconds.
|
@xabbuh should be fine now. Thanks |
|
👍 @javiereguiluz Good for you too? |
|
@xabbuh yes, it looks very nice! |
|
Thank you Dominik. |
xabbuh
added a commit
that referenced
this pull request
Jan 11, 2017
…ues (dominikhajduk) This PR was squashed before being merged into the 3.2 branch (closes #7315). Discussion ---------- [Workflow] Add tip for workflow configuration default values Added tip for http://symfony.com/doc/current/workflow/usage.html configuration. Tested and based on great examples provided by @lyrixx in: https://github.com/lyrixx/SFLive-Paris2016-Workflow/blob/master/app/config/workflow.yml#L3 and https://github.com/lyrixx/SFLive-Paris2016-Workflow/blob/master/src/AppBundle/Entity/Article.php#L24 Commits ------- 6262d24 [Workflow] Add tip for workflow configuration default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tip for http://symfony.com/doc/current/workflow/usage.html configuration.
Tested and based on great examples provided by @lyrixx in: https://github.com/lyrixx/SFLive-Paris2016-Workflow/blob/master/app/config/workflow.yml#L3 and
https://github.com/lyrixx/SFLive-Paris2016-Workflow/blob/master/src/AppBundle/Entity/Article.php#L24