Changing type definition of query_builder option: Closure by callable #8527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid confusion I suggest be consistent according to its own definition https://github.com/symfony/symfony/blob/f1468c48a5afc745899de48621465d29494ba086/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php#L43
In other docs, we wrap "callable" with quotes only in the option definition, not in the description. I made this change to be consistent ... but we can reconsider this if you disagree. Thanks!
javiereguiluz
approved these changes
Oct 19, 2017
|
Thank you @yceruto. |
xabbuh
added a commit
that referenced
this pull request
Oct 27, 2017
… by callable (yceruto, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Changing type definition of query_builder option: Closure by callable According to its own definition: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php#L43 Commits ------- fb64173 Minor syntax issue ab58080 Changing type definition Closure by callable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to its own definition:
https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php#L43