Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix code block syntax #9255

Merged
merged 1 commit into from Feb 13, 2018
Merged

fix code block syntax #9255

merged 1 commit into from Feb 13, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 13, 2018

No description provided.

@xabbuh xabbuh added this to the 3.4 milestone Feb 13, 2018
@xabbuh
Copy link
Member Author

xabbuh commented Feb 13, 2018

compare http://symfony.com/doc/3.4/service_container.html#multiple-service-definitions-using-the-same-namespace with http://pr-9255-gshotaa-6qmocelev2lwe.eu.platform.sh/service_container.html#multiple-service-definitions-using-the-same-namespace to spot the difference

javiereguiluz
javiereguiluz reviewed Feb 13, 2018
View reviewed changes
service_container.rst Outdated
tags: [event_subscriber]
# app/config/services.yml
services:
command_handlers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of these lines should be 8 white spaces instead of 1, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@javiereguiluz
Copy link
Member

Thanks Christian.

@javiereguiluz javiereguiluz merged commit 2fc00fc into symfony:3.4 Feb 13, 2018
javiereguiluz added a commit that referenced this pull request Feb 13, 2018
@javiereguiluz
minor #9255 fix code block syntax (xabbuh)
ac0590b 
This PR was merged into the 3.4 branch.

Discussion
----------

fix code block syntax

Commits
-------

2fc00fc fix code block syntax
@xabbuh xabbuh deleted the pr-8310 branch February 13, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xabbuh @javiereguiluz @carsonbot