Use FQCN as service ID #9392
Closed
Use FQCN as service ID #9392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slootjes just for your information: the 3.3 branch is no longer maintained (see https://symfony.com/roadmap) so we'll merge this in 3.4 branch. There's no need for you to rebase this because we can do it when merging. Thanks! |
|
I see the part about "oldest maintained branch" in the documentation contribution now, thanks for explaining. Do you want me to create another PR for 4.0 too or will you use this instead (as it's basically just renaming AppBundle to App)? |
|
@slootjes I think it will be done when merging too ;). Thanks for this contribution ;). |
Simperfit
approved these changes
Mar 6, 2018
|
👍 I like it! status: reviewed |
|
Thank you @slootjes. |
xabbuh
added a commit
that referenced
this pull request
Mar 23, 2018
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #9392). Discussion ---------- Use FQCN as service ID I was looking at this page in 4.0 and it seemed like a good idea to show the examples with the FQCN rather than names service IDs instead. If accepted I can also apply the same change to 4.0 branch if needed. Commits ------- 222b07f Use FQCN as service ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at this page in 4.0 and it seemed like a good idea to show the examples with the FQCN rather than names service IDs instead. If accepted I can also apply the same change to 4.0 branch if needed.