[Messenger] Give credits to where the messenger component were inspired from #9901
Conversation
|
Very classy move. 👍 Thanks for addressing this so gracefully, @Nyholm. |
There was a problem hiding this comment.
It totally makes sense to praise and highlight the work of our friend @matthiasnoback here!
Thanks Tobias for taking care of this. And thanks Matthias for being and inspiration for this component (and for many other things!)
|
It's merged now! (We merged it in 4.1) |
… were inspired from (Nyholm) This PR was submitted for the master branch but it was merged into the 4.1 branch instead (closes #9901). Discussion ---------- [Messenger] Give credits to where the messenger component were inspired from Our initial implementation of the Messenger component is **greatly** inspired by the work of Matthias Noback. It is obvious for anyone that used SimpleBus and see the messenger component. I think it is a good idea to give some credit and to make sure that we all users know that we are inspired by SimpleBus. Currently we only reference Matthias [here](https://github.com/symfony/symfony/blob/4.1/src/Symfony/Component/Messenger/MessageBus.php#L19). I do understand that the component has diverged from SimpleBus and we (Symfony community) have added many great features the past few months. But I hope we could include some version of this PR. Commits ------- d2d67d0 Give credits to Matthias Noback
|
Thank you for the reviews and for merging |
|
Hey everyone! Thanks for adding the credits, that's very kind. I personally didn't worry a lot about that though. I released SimpleBus under MIT license, with which I'm already kind of saying "do with it what you want". There is a more important issue with Symfony trying to take over the message bus market. The SimpleBus team and the Messenger maintenance team are from now on going to make the same effort, for every Symfony release and for every feature that needs to be added. That's why the lead maintainer of SimpleBus (@cmodijk), who has done a lot of work to keep the libraries up to date, is now considering to stop maintaining SimpleBus itself. There is no point in working on SimpleBus in parallel to the Symfony team's efforts, in particular because, afaik, SimpleBus and Messenger have feature parity. Instead, Cliff considers to look into developing a migration path to Symfony Messenger and proposing that to existing users. Which makes sense, but it's also sad, because SimpleBus has a fair amount of users, who we as the "SimpleBus organization" can't help anymore and who are going to have to put in some extra work. I wanted to share this story here, because I think this is the most painful aspect of "copying" SimpleBus into the Symfony organization. I really can't think of a good reason why it had to be done. Everything was/is already there, all the necessary integrations too, and everything works well, is well tested, and is actively maintained. Well, except the root namespace isn't "Symfony". Of course, it's not illegal to do what you did, but also remember that it's not just about the code. I know that things won't be reconsidered, that the Messenger component is already here, and here to stay, but I also didn't want to remain silent on this, and to point out some possibly unforeseen side-effects. And I definitely want us to remain friends, as I for one consider each of you, Javier, Tobias, and even Carsonbot to be very nice people, working hard for progress in an open source world. |
Our initial implementation of the Messenger component is greatly inspired by the work of Matthias Noback. It is obvious for anyone that used SimpleBus and see the messenger component. I think it is a good idea to give some credit and to make sure that we all users know that we are inspired by SimpleBus.
Currently we only reference Matthias here.
I do understand that the component has diverged from SimpleBus and we (Symfony community) have added many great features the past few months. But I hope we could include some version of this PR.