added a .travis.yml #432

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

lsmith77 commented Oct 14, 2012

please enable travis before merging this PR

Contributor

lsmith77 commented Oct 14, 2012

btw .. not sure if this was intentional but if you update composer you will need to do the following change:

diff --git a/app/config/config_test.yml b/app/config/config_test.yml
index f39c3cb..a27c240 100644
--- a/app/config/config_test.yml
+++ b/app/config/config_test.yml
@@ -6,7 +6,7 @@ framework:
     session:
         storage_id: session.storage.mock_file
     profiler:
-        enable: false
+        enabled: false

 web_profiler:
     toolbar: false
Member

stof commented Oct 14, 2012

hmm, looks like the change done by @schmittjoh to use the canBeDisabled shortcut needs to be reverted in this node, because it was using a different name.

Contributor

lsmith77 commented Oct 14, 2012

yeah .. but proofs it would be good to have a travis setup for this repo :)

also wondering if travis is already enabled for this repo, or if its running the PR test because its enabled in my repo?

Owner

fabpot commented Oct 14, 2012

Travis was already activated in the 2.1 branch. I've just merged it into master.

fabpot closed this Oct 14, 2012

Contributor

lsmith77 commented Oct 14, 2012

hmm i dont see the .travis.yml file in master .. did it get lost somehow during the merge?

Owner

fabpot commented Oct 14, 2012

weird. I don't understand how this is even possible!

Contributor

lsmith77 commented Oct 14, 2012

not sure how it happend .. but might be related to the fact that its a "." prefixed file.

Owner

fabpot commented Oct 15, 2012

I've just re-added it to master.

@lsmith77 lsmith77 added a commit to liip-forks/symfony-standard that referenced this pull request Oct 15, 2012

@lsmith77 lsmith77 Merge branch 'master' into techtalk
# By Fabien Potencier (8) and others
# Via Fabien Potencier
* master:
  re-added travis file (missing due to a bad merge, refs #432)
  You cannot start a Plain Style Scalar with an Indicator (%). Plain Style Scalars which have a leading % should be changed to double-quote style scalars.
  Correcting YAML Markup in app/config to be valid YAML 1.2o
  Update README.md
  updated VENDORS for 2.1.2
  finished reverting previous changes
  reverted unwanted changes
  updated deps
  Download Composer from a secure source
  added .travis.yml
  updated VENDORS for 2.1.1
  Revert "merged branch Tobion/patch-1 (PR #397)"
  fixed composer file
  Fixed an issue with installs from composer not working due to version conflict on symfony/symfony
  Add reference to PHP bug #62874 for 5.3.16 requirement
  Add more verbose warning for PHP 5.3.16

Conflicts:
	.travis.yml
bfb06ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment