bug #46535 [Mime] Check that the path is a file in the DataPart::from…

…Path (wkania)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Mime] Check that the path is a file in the DataPart::fromPath

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

The directory can also be readable. Fix to the [PR](#36304).

Found it while working on another fix related to this method.

Commits
-------

a807523 [Mime] Check that the path is a file in the DataPart::fromPath

src/Symfony/Component/Mime/Part/DataPart.php

@@ -61,7 +61,7 @@ public static function fromPath(string $path, string $name = null, string $conte
             $contentType = self::$mimeTypes->getMimeTypes($ext)[0] ?? 'application/octet-stream';
         }
 
-        if (false === is_readable($path)) {
+        if (!is_file($path) || !is_readable($path)) {
             throw new InvalidArgumentException(sprintf('Path "%s" is not readable.', $path));
         }
 

src/Symfony/Component/Mime/Tests/Part/DataPartTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Mime\Tests\Part;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Mime\Exception\InvalidArgumentException;
 use Symfony\Component\Mime\Header\Headers;
 use Symfony\Component\Mime\Header\IdentificationHeader;
 use Symfony\Component\Mime\Header\ParameterizedHeader;
@@ -127,6 +128,12 @@ public function testFromPathWithMeta()
         ), $p->getPreparedHeaders());
     }
 
+    public function testFromPathWithNotAFile()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        DataPart::fromPath(__DIR__.'/../Fixtures/mimetypes/');
+    }
+
     public function testHasContentId()
     {
         $p = new DataPart('content');