Skip to content

Commit

Permalink
minor #52245 [Form] skip tests that do not work with ICU 71.1 (xabbuh)
Browse files Browse the repository at this point in the history
This PR was merged into the 5.4 branch.

Discussion
----------

[Form] skip tests that do not work with ICU 71.1

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

6e9d9ab skip tests that do not work with ICU 71.1
  • Loading branch information
xabbuh committed Nov 30, 2023
2 parents ce95b87 + 6e9d9ab commit 0719891
Showing 1 changed file with 21 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Symfony\Component\Form\ChoiceList\View\ChoiceView;
use Symfony\Component\Form\FormError;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Intl\Intl;
use Symfony\Component\Intl\Util\IntlTestHelper;
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;

Expand Down Expand Up @@ -90,6 +91,10 @@ public function testSubmitFromSingleTextDateTime()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -112,6 +117,10 @@ public function testSubmitFromSingleTextDateTimeImmutable()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -135,6 +144,10 @@ public function testSubmitFromSingleTextString()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -157,6 +170,10 @@ public function testSubmitFromSingleTextTimestamp()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -181,6 +198,10 @@ public function testSubmitFromSingleTextRaw()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand Down

0 comments on commit 0719891

Please sign in to comment.