Skip to content

Commit

Permalink
bug #50540 [Validator] GH-50526: Reverting ExecutionContextInterface …
Browse files Browse the repository at this point in the history
…void return types in favor of docblock annotations. (upchuk)

This PR was merged into the 6.3 branch.

Discussion
----------

[Validator] GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations.

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #50526
| License       | MIT
| Doc PR        |

Commits
-------

7c7b0b2 GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations.
  • Loading branch information
nicolas-grekas committed Jun 5, 2023
2 parents 31d2b01 + 7c7b0b2 commit 1cceec1
Showing 1 changed file with 15 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -123,37 +123,44 @@ public function getObject(): ?object;
*
* @param object|null $object The currently validated object
* @param string $propertyPath The property path to the current value
*
* @return void
*/
public function setNode(mixed $value, ?object $object, MetadataInterface $metadata = null, string $propertyPath): void;
public function setNode(mixed $value, ?object $object, MetadataInterface $metadata = null, string $propertyPath);

/**
* Warning: Should not be called by user code, to be used by the validator engine only.
*
* @param string|null $group The validated group
*
* @return void
*/
public function setGroup(?string $group): void;
public function setGroup(?string $group);

/**
* Warning: Should not be called by user code, to be used by the validator engine only.
*
* @return void
*/
public function setConstraint(Constraint $constraint): void;
public function setConstraint(Constraint $constraint);

/**
* Warning: Should not be called by user code, to be used by the validator engine only.
*
* @param string $cacheKey The hash of the object
* @param string $groupHash The group's name or hash, if it is group
* sequence
*
* @return void
*/
public function markGroupAsValidated(string $cacheKey, string $groupHash): void;
public function markGroupAsValidated(string $cacheKey, string $groupHash);

/**
* Warning: Should not be called by user code, to be used by the validator engine only.
*
* @param string $cacheKey The hash of the object
* @param string $groupHash The group's name or hash, if it is group
* sequence
*
*/
public function isGroupValidated(string $cacheKey, string $groupHash): bool;

Expand All @@ -162,15 +169,16 @@ public function isGroupValidated(string $cacheKey, string $groupHash): bool;
*
* @param string $cacheKey The hash of the object
* @param string $constraintHash The hash of the constraint
*
* @return void
*/
public function markConstraintAsValidated(string $cacheKey, string $constraintHash): void;
public function markConstraintAsValidated(string $cacheKey, string $constraintHash);

/**
* Warning: Should not be called by user code, to be used by the validator engine only.
*
* @param string $cacheKey The hash of the object
* @param string $constraintHash The hash of the constraint
*
*/
public function isConstraintValidated(string $cacheKey, string $constraintHash): bool;

Expand All @@ -188,7 +196,6 @@ public function markObjectAsInitialized(string $cacheKey): void;
*
* @param string $cacheKey The hash of the object
*
*
* @see ObjectInitializerInterface
*/
public function isObjectInitialized(string $cacheKey): bool;
Expand Down

0 comments on commit 1cceec1

Please sign in to comment.