[Translation] Improve handling of non-string messages in ArrayLoader

symfony · May 13, 2023 · 3952042 · 3952042
1 parent d61b959
commit 3952042
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/src/Symfony/Component/Translation/Loader/ArrayLoader.php b/src/Symfony/Component/Translation/Loader/ArrayLoader.php
@@ -46,10 +46,12 @@ private function flatten(array $messages): array
         foreach ($messages as $key => $value) {
             if (\is_array($value)) {
                 foreach ($this->flatten($value) as $k => $v) {
-                    $result[$key.'.'.$k] = $v;
+                    if (null !== $v) {
+                        $result[$key.'.'.$k] = (string) $v;
+                    }
                 }
-            } else {
-                $result[$key] = $value;
+            } elseif (null !== $value) {
+                $result[$key] = (string) $value;
             }
         }
 

diff --git a/src/Symfony/Component/Translation/Tests/Loader/YamlFileLoaderTest.php b/src/Symfony/Component/Translation/Tests/Loader/YamlFileLoaderTest.php
@@ -30,6 +30,15 @@ public function testLoad()
         $this->assertEquals([new FileResource($resource)], $catalogue->getResources());
     }
 
+    public function testLoadNonStringMessages()
+    {
+        $loader = new YamlFileLoader();
+        $resource = __DIR__.'/../fixtures/non-string.yml';
+        $catalogue = $loader->load($resource, 'en', 'domain1');
+
+        $this->assertSame(['root.foo2' => '', 'root.bar' => 'bar', 'root.baz' => '1'], $catalogue->all('domain1'));
+    }
+
     public function testLoadDoesNothingIfEmpty()
     {
         $loader = new YamlFileLoader();

diff --git a/src/Symfony/Component/Translation/Tests/fixtures/non-string.yml b/src/Symfony/Component/Translation/Tests/fixtures/non-string.yml
@@ -0,0 +1,5 @@
+root:
+  foo1:
+  foo2: ''
+  bar: 'bar'
+  baz: 1