review changes

symfony · Mar 19, 2024 · 3ac96ef · 3ac96ef
1 parent c1b826e
commit 3ac96ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php
@@ -382,12 +382,7 @@ public static function create(string $uri, string $method = 'GET', array $parame
      */
     public static function setFactory(?callable $callable): void
     {
-        if(null === $callable) {
-            self::$requestFactory = null;
-            return;
-        }
-
-        self::$requestFactory = $callable(...);
+        self::$requestFactory = null === $callable ? null : $callable(...);
     }
 
     /**

diff --git a/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php b/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
@@ -2199,14 +2199,14 @@ public function testFactory()
 
     public function testFactoryCallable()
     {
-        $request_factory = new class {
-            public function createRequest(array $query = [], array $request = [], array $attributes = [], array $cookies = [], array $files = [], array $server = [], $content = null): Request
+        $requestFactory = new class {
+            public function createRequest(): Request
             {
                 return new NewRequest();
             }
         };
 
-        Request::setFactory([$request_factory, 'createRequest']);
+        Request::setFactory([$requestFactory, 'createRequest']);
 
         $this->assertEquals('foo', Request::create('/')->getFoo());