feature #40029 [DoctineBridge] Remove UuidV*Generator classes (nicola…

…s-grekas) This PR was merged into the 5.3-dev branch. Discussion ---------- [DoctineBridge] Remove UuidV*Generator classes | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - There is no benefit in using these classes over creating the UUIDs inline. Let's keep things simple. For `UlidGenerator`, I'm keeping it as it will provide something useful once #39507 and doctrine/DoctrineBundle#1284 are finished. Commits ------- 3c296bd [DoctineBridge] Remove UuidV*Generator
symfony · Jan 29, 2021 · 4537f85 · 4537f85
2 parents 0f4c905 + 3c296bd
commit 4537f85
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 184 deletions.
diff --git a/UPGRADE-5.3.md b/UPGRADE-5.3.md
@@ -6,6 +6,11 @@ Asset
 
  * Deprecated `RemoteJsonManifestVersionStrategy`, use `JsonManifestVersionStrategy` instead
 
+DoctrineBridge
+--------------
+
+ * Remove `UuidV*Generator` classes
+
 DomCrawler
 ----------
 

diff --git a/src/Symfony/Bridge/Doctrine/CHANGELOG.md b/src/Symfony/Bridge/Doctrine/CHANGELOG.md
@@ -4,7 +4,8 @@ CHANGELOG
 5.3
 ---
 
- * deprecated `DoctrineTestHelper` and `TestRepositoryFactory`
+ * Deprecate `DoctrineTestHelper` and `TestRepositoryFactory`
+ * [BC BREAK] Remove `UuidV*Generator` classes
 
 5.2.0
 -----

diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UlidGenerator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UlidGenerator.php
@@ -15,9 +15,6 @@
 use Doctrine\ORM\Id\AbstractIdGenerator;
 use Symfony\Component\Uid\Ulid;
 
-/**
- * @experimental in 5.2
- */
 final class UlidGenerator extends AbstractIdGenerator
 {
     public function generate(EntityManager $em, $entity): Ulid

diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV1Generator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV1Generator.php
diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV4Generator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV4Generator.php
diff --git a/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV6Generator.php b/src/Symfony/Bridge/Doctrine/IdGenerator/UuidV6Generator.php
diff --git a/src/Symfony/Bridge/Doctrine/Tests/IdGenerator/UuidV1GeneratorTest.php b/src/Symfony/Bridge/Doctrine/Tests/IdGenerator/UuidV1GeneratorTest.php
diff --git a/src/Symfony/Bridge/Doctrine/Tests/IdGenerator/UuidV4GeneratorTest.php b/src/Symfony/Bridge/Doctrine/Tests/IdGenerator/UuidV4GeneratorTest.php
diff --git a/src/Symfony/Bridge/Doctrine/Tests/IdGenerator/UuidV6GeneratorTest.php b/src/Symfony/Bridge/Doctrine/Tests/IdGenerator/UuidV6GeneratorTest.php