Skip to content

Commit

Permalink
minor #50935 [Validator] Do not mock metadata factory on debug comman…
Browse files Browse the repository at this point in the history
…d tests (loic425)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Validator] Do not mock metadata factory on debug command tests

| Q             | A
| ------------- | ---
| Branch?       |  5.4
| Bug fix?      | not really, but it will be usefull to fix that command
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Before #48840 I think this one could improve the tests.

Commits
-------

de6d15f [Validator] Do not mock metadata factory on debug command tests
  • Loading branch information
nicolas-grekas committed Jul 13, 2023
2 parents 97bd5a0 + de6d15f commit 67acf9e
Show file tree
Hide file tree
Showing 3 changed files with 107 additions and 140 deletions.

0 comments on commit 67acf9e

Please sign in to comment.