only suggest domain when locale is already typed

symfony · Oct 24, 2021 · 6e3598b · 6e3598b
1 parent 03000d7
commit 6e3598b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -332,9 +332,7 @@ public function complete(CompletionInput $input, CompletionSuggestions $suggesti
             return;
         }
 
-        if ($input->mustSuggestOptionValuesFor('domain')) {
-            $locale = $input->getArgument('locale');
-
+        if ($input->mustSuggestOptionValuesFor('domain') && $locale = $input->getArgument('locale')) {
             $extractedCatalogue = $this->extractMessages($locale, $this->getRootCodePaths($kernel), $input->getOption('prefix'));
 
             $currentCatalogue = $this->loadCurrentMessages($locale, $this->getRootTransPaths());

diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandCompletionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandCompletionTest.php
@@ -45,7 +45,8 @@ public function testComplete(array $input, array $expectedSuggestions)
     public function provideCompletionSuggestions()
     {
         yield 'bundle' => [['en', ''], ['BaseBundle']];
-        yield 'domain' => [['en', '--domain=m'], ['messages']];
+        yield 'domain with locale' => [['en', '--domain=m'], ['messages']];
+        yield 'domain without locale' => [['--domain=m'], []];
         yield 'format' => [['en', '--format='], ['php', 'xlf', 'po', 'mo', 'yml', 'yaml', 'ts', 'csv', 'ini', 'json', 'res', 'xlf12', 'xlf20']];
         yield 'sort' => [['en', '--sort='], ['asc', 'desc']];
     }