Skip to content

Commit

Permalink
minor #54536 [Validator] Fill in trans-unit id 113: This URL does not…
Browse files Browse the repository at this point in the history
… contain a TLD. (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] Fill in trans-unit id 113: This URL does not contain a TLD.

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Commits
-------

cf6151d [Validator] Fill in trans-unit id 113: This URL does not contain a TLD.
  • Loading branch information
nicolas-grekas committed Apr 11, 2024
2 parents 9226902 + cf6151d commit 886af6f
Show file tree
Hide file tree
Showing 56 changed files with 223 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .github/sync-translations.php
Expand Up @@ -108,6 +108,8 @@ function mergeDom(\DOMDocument $dom, \DOMNode $tree, \DOMNode $input)
if ($catalogue->defines($resname, $domain)) {
$translation = $catalogue->get($resname, $domain);
$metadata = $catalogue->getMetadata($resname, $domain);
} else {
$translation = $source;
}
$metadata['id'] = $enCatalogue->getMetadata($resname, $domain)['id'];
if ($resname !== $source) {
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/integration-tests.yml
Expand Up @@ -114,6 +114,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Install system dependencies
run: |
Expand Down Expand Up @@ -201,13 +203,11 @@ jobs:
- name: Check for changes in translation files
id: changed-translation-files
run: |
if git diff --quiet HEAD~1 HEAD -- 'src/**/Resources/translations/*.xlf'; then
echo "{changed}={true}" >> $GITHUB_OUTPUT
else
echo "{changed}={false}" >> $GITHUB_OUTPUT
fi
echo 'changed='$((git diff --quiet HEAD~1 HEAD -- 'src/**/Resources/translations/*.xlf' || (echo 'true' && exit 1)) && echo 'false') >> $GITHUB_OUTPUT
- name: Check Translation Status
if: steps.changed-translation-files.outputs.changed == 'true'
run: |
php src/Symfony/Component/Translation/Resources/bin/translation-status.php -v
php .github/sync-translations.php
git diff --exit-code src/ || (echo 'Run "php .github/sync-translations.php" to fix XLIFF files.' && exit 1)
Expand Up @@ -166,11 +166,11 @@ function extractLocaleFromFilePath($filePath)
function extractTranslationKeys($filePath)
{
$translationKeys = [];
$contents = new \SimpleXMLElement(file_get_contents($filePath));
$contents = new SimpleXMLElement(file_get_contents($filePath));

foreach ($contents->file->body->{'trans-unit'} as $translationKey) {
$translationId = (string) $translationKey['id'];
$translationKey = (string) $translationKey->source;
$translationKey = (string) ($translationKey['resname'] ?? $translationKey->source);

$translationKeys[$translationId] = $translationKey;
}
Expand Down
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Hierdie waarde is nie 'n geldige MAC-adres nie.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Hierdie URL bevat nie 'n topvlakdomein (TLD) nie.</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>هذه القيمة ليست عنوان MAC صالحًا.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">هذا الرابط لا يحتوي على نطاق أعلى مستوى (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Bu dəyər etibarlı bir MAC ünvanı deyil.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Bu URL üst səviyyəli domen (TLD) içərmir.</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Гэта значэнне не з'яўляецца сапраўдным MAC-адрасам.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Гэты URL не ўтрымлівае дамен верхняга ўзроўню (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Тази стойност не е валиден MAC адрес.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Този URL адрес не съдържа домейн от най-високо ниво (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Ova vrijednost nije valjana MAC adresa.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Ovaj URL ne sadrži domenu najvišeg nivoa (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Aquest valor no és una adreça MAC vàlida.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Aquesta URL no conté un domini de nivell superior (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Tato hodnota není platnou MAC adresou.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Tato URL neobsahuje doménu nejvyššího řádu (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Nid yw'r gwerth hwn yn gyfeiriad MAC dilys.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Nid yw'r URL hwn yn cynnwys parth lefel uchaf (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Denne værdi er ikke en gyldig MAC-adresse.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Denne URL indeholder ikke et topdomæne (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -136,7 +136,7 @@
</trans-unit>
<trans-unit id="37" resname="This is not a valid IP address.">
<source>This value is not a valid IP address.</source>
<target >Αυτή η IP διεύθυνση δεν είναι έγκυρη.</target>
<target>Αυτή η IP διεύθυνση δεν είναι έγκυρη.</target>
</trans-unit>
<trans-unit id="38">
<source>This value is not a valid language.</source>
Expand Down Expand Up @@ -320,7 +320,7 @@
</trans-unit>
<trans-unit id="83" resname="This is not a valid UUID.">
<source>This value is not a valid UUID.</source>
<target >Αυτός ο αριθμός δεν είναι έγκυρη UUID.</target>
<target>Αυτός ο αριθμός δεν είναι έγκυρη UUID.</target>
</trans-unit>
<trans-unit id="84">
<source>This value should be a multiple of {{ compared_value }}.</source>
Expand Down Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Αυτός ο αριθμός δεν είναι έγκυρη διεύθυνση MAC.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Αυτή η διεύθυνση URL δεν περιέχει έναν τομέα ανώτατου επιπέδου (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Este valor no es una dirección MAC válida.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Esta URL no contiene un dominio de nivel superior (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>See väärtus ei ole kehtiv MAC-aadress.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Sellel URL-il puudub ülataseme domeen (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Balio hau ez da MAC helbide baliozko bat.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">URL honek ez du goi-mailako domeinurik (TLD) du.</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">این مقدار یک آدرس MAC معتبر نیست.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">این URL شامل دامنه سطح بالا (TLD) نمی‌شود.</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Tämä arvo ei ole kelvollinen MAC-osoite.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Tämä URL-osoite ei sisällä ylätason verkkotunnusta (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Cette valeur n'est pas une adresse MAC valide.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target>Cette URL ne contient pas de domaine de premier niveau (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Este valor non é un enderezo MAC válido.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Esta URL non contén un dominio de nivel superior (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">ערך זה אינו כתובת MAC תקפה.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">כתובת URL זו אינה מכילה דומיין רמה עליונה (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Ova vrijednost nije valjana MAC adresa.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Ovaj URL ne sadrži najvišu razinu domene (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Ez az érték nem érvényes MAC-cím.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Ez az URL nem tartalmaz felső szintű domain-t (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Այս արժեքը վավեր MAC հասցե չէ։</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Այս URL-ը չունի վերին մակարդակի դոմեյն (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Nilai ini bukan alamat MAC yang valid.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">URL ini tidak mengandung domain tingkat atas (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target>Questo valore non è un indirizzo MAC valido.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Questo URL non contiene un dominio di primo livello (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">この値は有効なMACアドレスではありません。</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">このURLにはトップレベルドメイン(TLD)が含まれていません。</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Dëse Wäert ass keng gülteg MAC-Adress.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Dësen URL enthält keng Top-Level-Domain (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Ši vertė nėra galiojantis MAC adresas.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Šis URL neturi aukščiausio lygio domeno (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Оваа вредност не е валидна MAC адреса.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Овој URL не содржи домен од највисоко ниво (TLD).</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">Энэ утга хүчинтэй MAC хаяг биш юм.</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">Энэ URL нь дээд түвшингийн домейн (TLD)-гүй байна.</target>
</trans-unit>
</body>
</file>
</xliff>
Expand Up @@ -438,6 +438,10 @@
<source>This value is not a valid MAC address.</source>
<target state="needs-review-translation">ဤတန်ဖိုးသည် မှန်ကန်သော MAC လိပ်စာ မဟုတ်ပါ။</target>
</trans-unit>
<trans-unit id="113">
<source>This URL does not contain a TLD.</source>
<target state="needs-review-translation">ဤ URL သည် အမြင့်ဆုံးအဆင့်ဒိုမိန်း (TLD) မပါရှိပါ။</target>
</trans-unit>
</body>
</file>
</xliff>

0 comments on commit 886af6f

Please sign in to comment.