[HttpClient] Add resolve option to Copy as Curl

symfony · Mar 15, 2022 · 88b1b8f · 88b1b8f
1 parent 9b2587e
commit 88b1b8f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php b/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php
@@ -175,6 +175,15 @@ private function getCurlCommand(array $trace): ?string
         $url = $trace['url'];
         $command = ['curl', '--compressed'];
 
+        if (isset($trace['options']['resolve'])) {
+            $port = parse_url($url, \PHP_URL_PORT) ?: (str_starts_with('http:', $url) ? 80 : 443);
+            foreach ($trace['options']['resolve'] as $host => $ip) {
+                if (null !== $ip) {
+                    $command[] = '--resolve '.escapeshellarg("$host:$port:$ip");
+                }
+            }
+        }
+
         $dataArg = [];
 
         if ($json = $trace['options']['json'] ?? null) {

diff --git a/src/Symfony/Component/HttpClient/Tests/DataCollector/HttpClientDataCollectorTest.php b/src/Symfony/Component/HttpClient/Tests/DataCollector/HttpClientDataCollectorTest.php
@@ -194,6 +194,26 @@ public function provideCurlRequests(): iterable
   --url %1$shttp://localhost:8057/json%1$s \\
   --header %1$sAccept: */*%1$s \\
   --header %1$sAccept-Encoding: gzip%1$s \\
+  --header %1$sUser-Agent: Symfony HttpClient/Native%1$s',
+        ];
+        yield 'GET with resolve' => [
+            [
+                'method' => 'GET',
+                'url' => 'http://localhost:8057/json',
+                'options' => [
+                    'resolve' => [
+                        'localhost' => '127.0.0.1',
+                        'example.com' => null,
+                    ],
+                ],
+            ],
+            'curl \\
+  --compressed \\
+  --resolve %1$slocalhost:8057:127.0.0.1%1$s \\
+  --request GET \\
+  --url %1$shttp://localhost:8057/json%1$s \\
+  --header %1$sAccept: */*%1$s \\
+  --header %1$sAccept-Encoding: gzip%1$s \\
   --header %1$sUser-Agent: Symfony HttpClient/Native%1$s',
         ];
         yield 'POST with string body' => [