minor #41803 [Uid] Prevent double validation in Uuid::fromString() wi…

…th base32 values (fancyweb)

This PR was merged into the 5.3 branch.

Discussion
----------

[Uid] Prevent double validation in Uuid::fromString() with base32 values

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow up to #41693, it should be a little bit faster if we don't validate twice, right?

Commits
-------

043ee56 [Uid] Prevent double validation in Uuid::fromString() with base32 values

src/Symfony/Component/Uid/Ulid.php

@@ -43,7 +43,7 @@ public function __construct(string $ulid = null)
             throw new \InvalidArgumentException(sprintf('Invalid ULID: "%s".', $ulid));
         }
 
-        $this->uid = strtr($ulid, 'abcdefghjkmnpqrstvwxyz', 'ABCDEFGHJKMNPQRSTVWXYZ');
+        $this->uid = strtoupper($ulid);
     }
 
     public static function isValid(string $ulid): bool

src/Symfony/Component/Uid/Uuid.php

@@ -54,7 +54,9 @@ public static function fromString(string $uuid): parent
             $uuid = substr_replace($uuid, '-', 18, 0);
             $uuid = substr_replace($uuid, '-', 23, 0);
         } elseif (26 === \strlen($uuid) && Ulid::isValid($uuid)) {
-            $uuid = (new Ulid($uuid))->toRfc4122();
+            $ulid = new Ulid('00000000000000000000000000');
+            $ulid->uid = strtoupper($uuid);
+            $uuid = $ulid->toRfc4122();
         }
 
         if (__CLASS__ !== static::class || 36 !== \strlen($uuid)) {