-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #40537 [Security] Handle properly 'auto' option for remember me c…
…ookie security (fliespl) This PR was merged into the 4.4 branch. Discussion ---------- [Security] Handle properly 'auto' option for remember me cookie security | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40471 | License | MIT | Doc PR | n/a Manually setting remember_me cookie secure as auto is still is being set as secure one even if used over http. This PR fixes this behaviour by converting auto to null prior setting it up for service. Commits ------- 2bcf69c [Security] Handle properly 'auto' option for remember me cookie security
- Loading branch information
Showing
5 changed files
with
75 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/Symfony/Bundle/SecurityBundle/Tests/Functional/RememberMeCookieTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?php | ||
|
||
namespace Symfony\Bundle\SecurityBundle\Tests\Functional; | ||
|
||
use Symfony\Component\HttpFoundation\ResponseHeaderBag; | ||
|
||
class RememberMeCookieTest extends AbstractWebTestCase | ||
{ | ||
/** @dataProvider getSessionRememberMeSecureCookieFlagAutoHttpsMap */ | ||
public function testSessionRememberMeSecureCookieFlagAuto($https, $expectedSecureFlag) | ||
{ | ||
$client = $this->createClient(['test_case' => 'RememberMeCookie', 'root_config' => 'config.yml']); | ||
|
||
$client->request('POST', '/login', [ | ||
'_username' => 'test', | ||
'_password' => 'test', | ||
], [], [ | ||
'HTTPS' => (int) $https, | ||
]); | ||
|
||
$cookies = $client->getResponse()->headers->getCookies(ResponseHeaderBag::COOKIES_ARRAY); | ||
|
||
$this->assertEquals($expectedSecureFlag, $cookies['']['/']['REMEMBERME']->isSecure()); | ||
} | ||
|
||
public function getSessionRememberMeSecureCookieFlagAutoHttpsMap() | ||
{ | ||
return [ | ||
[true, true], | ||
[false, false], | ||
]; | ||
} | ||
} |
9 changes: 9 additions & 0 deletions
9
src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/RememberMeCookie/bundles.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<?php | ||
|
||
use Symfony\Bundle\FrameworkBundle\FrameworkBundle; | ||
use Symfony\Bundle\SecurityBundle\SecurityBundle; | ||
|
||
return [ | ||
new FrameworkBundle(), | ||
new SecurityBundle(), | ||
]; |
25 changes: 25 additions & 0 deletions
25
src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/RememberMeCookie/config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
imports: | ||
- { resource: ./../config/framework.yml } | ||
|
||
security: | ||
encoders: | ||
Symfony\Component\Security\Core\User\User: plaintext | ||
|
||
providers: | ||
in_memory: | ||
memory: | ||
users: | ||
test: { password: test, roles: [ROLE_USER] } | ||
|
||
firewalls: | ||
default: | ||
form_login: | ||
check_path: login | ||
remember_me: true | ||
require_previous_session: false | ||
remember_me: | ||
always_remember_me: true | ||
secret: key | ||
secure: auto | ||
logout: ~ | ||
anonymous: ~ |
2 changes: 2 additions & 0 deletions
2
src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/RememberMeCookie/routing.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
login: | ||
path: /login |