[Notifier] moved the deprecation to the factory

symfony · May 24, 2023 · b4dcd18 · b4dcd18
1 parent 13a49d4
commit b4dcd18
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 10 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php
@@ -283,11 +283,11 @@
         ->set('notifier.transport_factory.simple-textin', Bridge\SimpleTextin\SimpleTextinTransportFactory::class)
             ->parent('notifier.transport_factory.abstract')
             ->tag('texter.transport_factory')
-    
+
         ->set('notifier.transport_factory.click-send', Bridge\ClickSend\ClickSendTransportFactory::class)
             ->parent('notifier.transport_factory.abstract')
             ->tag('texter.transport_factory')
-    
+
         ->set('notifier.transport_factory.smsmode', Bridge\Smsmode\SmsmodeTransportFactory::class)
             ->parent('notifier.transport_factory.abstract')
             ->tag('texter.transport_factory')

diff --git a/src/Symfony/Component/Notifier/Bridge/Brevo/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Brevo/CHANGELOG.md
@@ -4,4 +4,4 @@ CHANGELOG
 6.3
 ---
 
-* Added the bridge
+* Added the bridge as a replacement of the Sendinblue one.
diff --git a/src/Symfony/Component/Notifier/Bridge/Brevo/composer.json b/src/Symfony/Component/Notifier/Bridge/Brevo/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "symfony/brevo-notifier",
     "type": "symfony-notifier-bridge",
-    "description": "Symfony Brevo Notifier Bridge",
+    "description": "Symfony Brevo Notifier Bridge - formerly Sendinblue",
     "keywords": ["brevo", "notifier"],
     "homepage": "https://symfony.com",
     "license": "MIT",

diff --git a/src/Symfony/Component/Notifier/Bridge/Sendinblue/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Sendinblue/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+6.3
+---
+
+* Deprecated the bridge, replaced it with Brevo in reaction to their rebranding.
+
 6.2
 ---
 

diff --git a/src/Symfony/Component/Notifier/Bridge/Sendinblue/SendinblueTransport.php b/src/Symfony/Component/Notifier/Bridge/Sendinblue/SendinblueTransport.php
@@ -11,7 +11,6 @@
 
 namespace Symfony\Component\Notifier\Bridge\Sendinblue;
 
-use Symfony\Component\Notifier\Bridge\Brevo\BrevoTransport;
 use Symfony\Component\Notifier\Exception\TransportException;
 use Symfony\Component\Notifier\Exception\UnsupportedMessageTypeException;
 use Symfony\Component\Notifier\Message\MessageInterface;
@@ -22,8 +21,6 @@
 use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
-trigger_deprecation('symfony/sendinblue-notifier', '6.3', 'The "%s" class is deprecated, use "%s" instead.', SendinblueTransport::class, BrevoTransport::class);
-
 /**
  * @author Pierre Tondereau <pierre.tondereau@gmail.com>
  *

diff --git a/src/Symfony/Component/Notifier/Bridge/Sendinblue/SendinblueTransportFactory.php b/src/Symfony/Component/Notifier/Bridge/Sendinblue/SendinblueTransportFactory.php
@@ -16,8 +16,6 @@
 use Symfony\Component\Notifier\Transport\AbstractTransportFactory;
 use Symfony\Component\Notifier\Transport\Dsn;
 
-trigger_deprecation('symfony/sendinblue-notifier', '6.3', 'The "%s" class is deprecated, use "%s" instead.', SendinblueTransport::class, BrevoTransport::class);
-
 /**
  * @author Pierre Tondereau <pierre.tondereau@protonmail.com>
  *
@@ -27,6 +25,8 @@ final class SendinblueTransportFactory extends AbstractTransportFactory
 {
     public function create(Dsn $dsn): SendinblueTransport
     {
+        trigger_deprecation('symfony/sendinblue-notifier', '6.3', 'The "%s" class is deprecated, use "%s" instead.', SendinblueTransport::class, BrevoTransport::class);
+
         $scheme = $dsn->getScheme();
 
         if ('sendinblue' !== $scheme) {

diff --git a/src/Symfony/Component/Notifier/Bridge/Sendinblue/composer.json b/src/Symfony/Component/Notifier/Bridge/Sendinblue/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "symfony/sendinblue-notifier",
     "type": "symfony-notifier-bridge",
-    "description": "Symfony Sendinblue Notifier Bridge",
+    "description": "Symfony Sendinblue Notifier Bridge - deprecated",
     "keywords": ["sms", "sendinblue", "notifier"],
     "homepage": "https://symfony.com",
     "license": "MIT",