initialize serializer in trait with null

symfony · Apr 5, 2024 · dae3726 · dae3726
1 parent 524c703
commit dae3726
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Symfony/Component/Serializer/SerializerAwareTrait.php b/src/Symfony/Component/Serializer/SerializerAwareTrait.php
@@ -16,7 +16,7 @@
  */
 trait SerializerAwareTrait
 {
-    protected SerializerInterface $serializer;
+    protected ?SerializerInterface $serializer = null;
 
     public function setSerializer(SerializerInterface $serializer): void
     {

diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
@@ -885,6 +885,16 @@ public function testSamePropertyAsMethodWithMethodSerializedName()
 
         $this->assertSame($expected, $this->normalizer->normalize($object));
     }
+
+    public function testNormalizeWithoutSerializerSet()
+    {
+        $normalizer = new ObjectNormalizer(new ClassMetadataFactory(new AttributeLoader()));
+
+        $this->expectException(LogicException::class);
+        $this->expectExceptionMessage('Cannot normalize attribute "foo" because the injected serializer is not a normalizer.');
+
+        $normalizer->normalize(new ObjectConstructorDummy([], [], []));
+    }
 }
 
 class ProxyObjectDummy extends ObjectDummy