bug #48971 [DependencyInjection] Fix dump order of inlined deps (nico…

…las-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Fix dump order of inlined deps

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #48895
| License       | MIT
| Doc PR        | -

Fix confirmed on the provided reproducers.
The updated fixture makes more sense also.

Commits
-------

1d01452 [DependencyInjection] Fix dump order of inlined deps

src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php

@@ -497,7 +497,7 @@ private function collectCircularReferences(string $sourceId, array $edges, array
                             $loop = [];
                         }
                     }
-                    $this->addCircularReferences($first, $loop, true);
+                    $this->addCircularReferences($first, $loop, $loopByConstructor);
                     break;
                 }
             }

src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services_almost_circular_private.php

@@ -421,17 +421,16 @@ protected function getMonologInline_LoggerService()
      */
     protected function getPAService()
     {
-        $a = new \stdClass();
-
-        $b = ($this->privates['pC'] ?? $this->getPCService());
+        $a = ($this->privates['pC'] ?? $this->getPCService());
 
         if (isset($this->services['pA'])) {
             return $this->services['pA'];
         }
+        $b = new \stdClass();
 
-        $this->services['pA'] = $instance = new \stdClass($a, $b);
+        $this->services['pA'] = $instance = new \stdClass($b, $a);
 
-        $a->d = ($this->privates['pD'] ?? $this->getPDService());
+        $b->d = ($this->privates['pD'] ?? $this->getPDService());
 
         return $instance;
     }