[WebServerBundle] Add types to constructors and private/final/interna…

…l methods.
symfony · Sep 30, 2019 · e4cfa7e · e4cfa7e
1 parent b6c461b
commit e4cfa7e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php
@@ -125,7 +125,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
     }
 
-    private function getLogs($socket)
+    private function getLogs($socket): iterable
     {
         $sockets = [(int) $socket => $socket];
         $write = [];
@@ -148,7 +148,7 @@ private function getLogs($socket)
         }
     }
 
-    private function displayLog(InputInterface $input, OutputInterface $output, $clientId, array $record)
+    private function displayLog(InputInterface $input, OutputInterface $output, int $clientId, array $record)
     {
         if (isset($record['log_id'])) {
             $clientId = unpack('H*', $record['log_id'])[1];

diff --git a/src/Symfony/Bundle/WebServerBundle/DependencyInjection/WebServerExtension.php b/src/Symfony/Bundle/WebServerBundle/DependencyInjection/WebServerExtension.php
@@ -46,7 +46,7 @@ public function load(array $configs, ContainerBuilder $container)
         @trigger_error('Using the WebserverBundle is deprecated since Symfony 4.4, the new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);
     }
 
-    private function getPublicDirectory(ContainerBuilder $container)
+    private function getPublicDirectory(ContainerBuilder $container): string
     {
         $kernelProjectDir = $container->getParameter('kernel.project_dir');
         $publicDir = 'public';

diff --git a/src/Symfony/Bundle/WebServerBundle/WebServer.php b/src/Symfony/Bundle/WebServerBundle/WebServer.php
@@ -174,7 +174,7 @@ private function createServerProcess(WebServerConfig $config): Process
         return $process;
     }
 
-    private function getDefaultPidFile()
+    private function getDefaultPidFile(): string
     {
         return ($this->pidFileDirectory ?? getcwd()).'/.web-server-pid';
     }