form_rest() renders fields that have already been rendered with form_widget()

[RogerWebb]

Form fields rendered individually with form_widget(...) or form_row(...) are re-rendered via form_rest(...)
This issue is related to beta2 and was not present in beta1.

Example:

{{ form_row(borrower_form.contact_info.first_name) }} {{ form_row(borrower_form.contact_info.last_name) }} Phone Number
{{ form_widget(phone_number_form.phone_type) }} {{ form_widget(phone_number_form.phone_number, { 'attr': { 'style': 'width:120px;' } }) }} ext. {{ form_widget(phone_number_form.extension, { 'attr': { 'style': 'width:40px;' } }) }}

When I call form_rest(...) at the end of the form, all of the above fields are rendered again.

[vicb]

Must be linked to this commit, sorry about that. This definitely need to be fixed and more tests should be added.
I won't be able to look into this before next Monday.

[johnwards]

This isn't fixed and is still happening in master.

Bundle here replicating the issue.

https://github.com/johnwards/FormDemoBundle

[stloyd]

@johnwards can you test my "fix" ? For me it's working properly with it.

[ebernhardson]

I can verify stloyd's "fix" worked against my installation. It is a per-item fix though so if you were to only use form_widget and form_errors when form_rest is called the label will be rendered by itself. I cant really comment on if that part is valid or not.

[vicb]

@stloyd your fix is probably a step in the right direction. We should be able to achieve the same result by using the FormView class rendered property (your fix basically duplicates this info in the extension).

But may be we should start by adding some unit tests.

Once we have some those tests available we should fix both the twig extension and the php helper.

[stloyd]

@vicb I already moved it to FormView locally but not I'm sure it will be much better than this one I already commited ;-), but didn't wrote any test. Probably tomorrow I will commit something.

[stloyd]

@vicb / @ebernhardson Can you just test my "fix" (#1186) ?

[kriswallsmith]

I've also suggested a fix in the #1115 comment thread.

[fabpot]

fixed here: #1221